* 🎉 Uxtweaks-panel på forsiden til Aksel
* 🎨 Flyttet uxtweaks-box til under god-praksis panel
* 🎨 Panel har nå aside med role presentation
Dette gjør at skjermlesere hopper over 'complementary' og kommer rett til heading
* 💄 Oppdatert heading-tekst
* ♻️ Oppdatert hvordan ModalContext leveres
* 🏷️ onBeforeClose krever nå boolean
* ♻️ Undo rename av Modal.types for å unngå conflict
* 📝 Changeset
* 🔥 Fjernet unødvendig story-oppdatering
* 🐛 Fikset forwardRef i createContext
I tilfellene der ref blir sendt inn som en context-value, ble den tidligere slettet av React (native oppførsel)
ForwardRef lar oss beholde ref og sende den inn som context-value
* Endring av strict
* null -> undefined
---------
Co-authored-by: Halvor Haugan <halvor.haugan@nav.no>
* 🎉 Egen Portal-komponent
* 🎨 Portal og Overlay exportert i root
* ♻️ Tooltip bruker egen Portal
* 📝 Changeset
* 🔥 Fjernet ID på Portal-element
* 🎉 Ny type WithAsChild
* ♻️ Mer robust sjekk for conditional elements i WithAsChild
* 📝 WithAsChild JSDOC
* 📝 WithAsChild JSDOC 2
* Update .changeset/lovely-points-heal.md
Co-authored-by: Halvor Haugan <83693529+HalvorHaugan@users.noreply.github.com>
* ♻️ Fikset kommentarer fra git-pr
---------
Co-authored-by: Halvor Haugan <83693529+HalvorHaugan@users.noreply.github.com>
* ❇️ new schema for view tracking
* 🚧 wip for article views schema
* 🚧 wip on schema
* 🚧 schema changes for ArticleViews
* 🚧 run prettier with new config
* 🚧 deno script to update article views
* 🚧 working sanity document updates with bogus view data
* 🚧 helper to delete all article_views
* 🚧 add views_day
* ✨ working update for views on all gp articles
* 💄 eye icon for page views in sanity studio
* ♻️ cleanup from PR review / huddle
* 🚧 improvements to updateViews script
* 🚧 seemingly healthy queries (sometimes proxy gives stale data?)
* 👷 add .github/workflow for update views
* 👷 update .github/workflow for update views
* 👷 add env var in workflow
* ♻️ refactor from PR comments
* ♻️ refactor from PR comments
* ♻️ refactor from PR comments
* ♻️ refactor from PR comments
* ♻️ refactor from PR comments
* ♻️ refactor from PR comments
* ♻️ refactor from PR comments
* 👷 update workflow
* 🐛 correct paths to changelog script
* 🐛 remove unused ?? -1
* 👷 dockerfile and naisjob.yml
* 👷 yml variable formatting
* 👷 yml update
* 👷 yml variable formatting
* 🔨 .prettierignore for all yml/yaml starting with nais
* 👷 unique name for naisjob
* 👷 new nais yaml
* 👷 yml variable formatting
* 👷 remove workflow, the workflow is developed in main
* 👷 update yml
* 🚧 update naisjob yml
* 🚧 update naisjob yml
* 🚧 update Dockerfile
* 🚧 update Dockerfile (permissions)
* 🚧 update Dockerfile
* 🚧 update Dockerfile
* 🚧 update Dockerfile
* 👷 decouple config code from rest of repo (more duplication, more robustness), build with correct docker context
* 👷 cache deps in dockerfile on build-time (no need to fetch at runtime and add to pod AccessPolicy)
* 👷 relative path might work, test Dockerfile live as it works fine locally... buildx?!
* 👷 test github action docker context tweak
* 👷 test script command entrypoint (workdir is not project root)
* 👷 add AccessPolicy for reops-proxy
* 👷 better github workflow naming
* 👷 refactor _and_ optimize the dockerfile
* 👷 new docker command path for nais yml
* Update scripts/article-views/queries.ts
Co-authored-by: Ken <26967723+KenAJoh@users.noreply.github.com>
* 👷 do not add rows if no data
* 🐛 fix sanity query) + now delete + update in single transaction
---------
Co-authored-by: Ken <26967723+KenAJoh@users.noreply.github.com>
* yarn lock
* setting up maxSelectedOptions
* added correct margin
* Update tsconfig.build.json
* Make border of "max selected"-item in FilteredOptions overlap the list border
* Hide "add new value"-button if "max selected"-limit is reached
* Make MaxSelected example a bit more interactive
* wip styling max-selected option
* Disable filteredOptions that are not selected when maxSelectedOptions is reached
* Fix scrolling/clipping content in FilteredOptions
* Remove hover-effects from non-selectable options
* add prop so user can customize message shown when max num of choices reached
* Operate directly on the DOM nodes when moving virtual focus, instead of relying on index state.
The index state became stale/non-synced when replacing elements in the list.
* make maxSelectedMessage static
* Remove max-selected:hover
Co-authored-by: Vegard Haugstvedt <it.vegard@gmail.com>
* yarn lock update
* 'cursor: not allowed' only hits disabled options
* remove li-margins, add ul-gap with negative margin on max-selected-option
* remove 'a' from initialstate maxSelectedOptions Story
* Update @navikt/core/css/form/combobox.css
* Update @navikt/core/css/form/combobox.css
* Update @navikt/core/react/src/form/combobox/FilteredOptions/FilteredOptions.tsx
* Update @navikt/core/react/src/form/combobox/FilteredOptions/useVirtualFocus.ts
* Update @navikt/core/react/src/form/combobox/FilteredOptions/useVirtualFocus.ts
* Update @navikt/core/react/src/form/combobox/combobox.stories.tsx
* type assertion
* remove tab-index on wrapper div
* prototype for sticky non-selectable options
* "yarn lock"
* Fix feil med at focus-indikator for input-feltet ikke ble vist
* Forenkle og fikse "scroll til element" i FilteredOptions
* Sørg for at disabled FilteredOptions ikke vises under "max antall"-meldingen
* Focused option should not be covered by "max selected" message
* yarn lock
* Fix "scrollIntoView is not a function" error. Possibly needs to be checked for when it occurs, but I haven't figured it out yet
* Loading indicator is no longer exposed as an option, so we have to just search for it by the accessible name.
Should have been able to use findByRole("graphics-document", { name: "Søker..." }), but that is currently broken:
https://github.com/testing-library/dom-testing-library/issues/1131
* Aria-selected should not be placed on elements that are no longer role="option"
* Combine all "max selected options"-related props in one object
* Proper BEM syntax should use -- instead of __ for state-like classes, like --loading, --max-selected and --new-option
* Always show selected options in FilteredOptions, even if they don't match the search text
* Only to the getElementsAbleToReceiveFocus() call once per function, to reduce DOM lookups. Also changed isFocusOnThe[Top | Bottom] to functions, because it was needed for isFocusOnTheBottom to follow the same rule (and not store the value on the top level in the hook.
* Pressing "End" should not only move focus to the end of the list, but also open the list if it is closed. To mirror this, we close the list if moving focus back to the Input with "Home".
* Legg til Aksel-eksempel
* yarn changeset
* Update @navikt/core/css/form/combobox.css
* change 'maxSelectedOptions' prop to 'maxSelected'
* Mark disabled options with aria-disabled
* Add max selected text to aria-describedby, so it is announced when the user enters the input field
* Add role="status" to the wrapper for "no hits", "loading" and "max selected" info messages, so they are announced when they appear
* Remove aria-selected (again)
* fix: form error not showing correctly
* fix: rm left hover-border on add-new-option item
* Bare åpne listen som default, men la intern logikk styre etter første render
* Sticky trenger ikke ligger på hver enkelt av disse, da parent wrapperen også er sticky
* Combobox eksempler var ikke tilgjengelig i `yarn storybook:aksel` på grunn av manglende Demo-eksport
* Fjern ubrukt klasse som er i konflikt med navds-combobox__wrapper
* Trengs ikke etter at max selected ble flyttet ut av listen
* Denne koden gjør ingenting
* Trenger ikke bruke :not, fordi vi tok vekk data-no-focus i en commit tidligere i dag
* Bruk dynamiske selectedOptions for å kunne endre de
* Update @navikt/core/css/form/combobox.css
Co-authored-by: Ken <26967723+KenAJoh@users.noreply.github.com>
* Update @navikt/core/react/src/form/combobox/FilteredOptions/FilteredOptions.tsx
Co-authored-by: Ken <26967723+KenAJoh@users.noreply.github.com>
* Update aksel.nav.no/website/pages/eksempler/combobox/with-max-selected-limit.tsx
Co-authored-by: Halvor Haugan <83693529+HalvorHaugan@users.noreply.github.com>
* Update @navikt/core/css/form/combobox.css
* Do not render an empty ul for FilteredOptions, as it add a gap at the bottom of the container
* Do not render an empty non-selectables container, as it adds a gap at the top of the container
* Non-selectables should not have navds-combobox__list-item class, as it introduces a few issues with hovering, etc.
* Copy-pasted in an extra class that broke styling for max selected
---------
Co-authored-by: Vegard Haugstvedt <it.vegard@gmail.com>
Co-authored-by: Ken <26967723+KenAJoh@users.noreply.github.com>
Co-authored-by: Halvor Haugan <83693529+HalvorHaugan@users.noreply.github.com>
* forslag til ny styling av code
* Update aksel.nav.no/website/components/website-modules/InlineCode.tsx
---------
Co-authored-by: Ken <26967723+KenAJoh@users.noreply.github.com>
* 🎉 Ny hook og API 'descendants'
* 📝 Bedre storiers
* 🐛 Fikset type-mismatch mellom create-context og useDescendant
* 🐛 Fikset value setting i provider
* 🏷️ Fikset kommentert ut ts-feil
* 🎨 tester bruk av disabled
* 🔥 Fjernet unødvendig id-kobling i descendants typer
* ❇️ new schema for view tracking
* 🚧 wip for article views schema
* 🚧 wip on schema
* 🚧 schema changes for ArticleViews
* 🚧 run prettier with new config
* ✨ Synket ikoner
* :coffing: Fjernet ikoner med [ignore-docs] i descrption
* ✨ Nytt ikon FigureChild
* 📝 changeset
* 🐛 La tilbake ikoner som ble slettet
* 🚚 Flyttet useClientLayoutEffect
* 🚚 Flyttet useEventListener
* 🚚 Flyttet resterende hooks
* 🎨 Oppdatert imports av hooks
* 🚚 Flyttet Randomicon util til link-ikon
* 🚚 Flyttet overridablecomponent inn i egen types mappe
* 📝 Changeset
* 📝 Eksempler for controlled switch
* 🔥 Fjernet console.logs
* ♻️ Mer beskrivende eksempel for controlled-value eksempel
* ♻️ Bedre praksis for switch-eksempler
* 🎉 Tag har nå egen icon-prop
* 🎨 Tag.css tilpasset ikoner
* 📝 Storybook-demo for tags + ikoner
* 📝 Aksel-demo for tag
* 📝 Changeset
* 🔥 Fjernet iconPosition-prop fra tag.tsx
* 🧪 Oppdatert stories med nye props
* 🔥 Fjernet iconPosition-demo i Tag fra nettside
* 🔥 Fjernet gammel css for iconPosition right tag.tsx
* 🎨 La til ny token
* 🐛 maksbredde var kalkulert feil
* 💄 CSS for max-width text
* 📝 Changeset og bedre dokumentasjon
* 🐛 Docs for max-width token
* 🎨 tailwind-støtte for ny maxWidth-token
* 🎨 rem -> px
* 📝 Dynamic padding-inline -> gutters
* ♻️ Fjernet duplikat padding-inline
* ♻️ Oppdatert token-navn fra max-width-text -> text-width-max
* 🐛 Fikset key i token-docs
* 📝 Changeset for ny token
* 🎨 Added useControllableState
* 🎨 Forbedret Accordion-api for controlled
* 🎨 Forbedret readmore-api for controlled
* 🎨 Forbedret internt expandablerow-api for controlled open
* 🎨 Forbedret tooltip-api for controlled open
* 🎨 Forbedret dropdown-api for controlled open
* 📝 La til dokumentasjon
* 📝 changeset
* 📝 Bedre kommentarer
* 🎨 Forenklet hooks
* 🎨 DefaultValue er required i useControllabeState
* ⚡ Erstattet pretty-quick med lint-staged
* ⬇️ Bruker eldre versjon av prettier (cjs) for codemod-tester
* 🐛 Bruker nå root prettie-versjon for codemods, bruker-experimental-vm-modules for codemod-jest
* Remove aria-invalid from individual Radio components because it is placed on the FieldSet
* Radio label and description should only be announced once with a screen reader
* Legg til mer realistiske tekster i eksempelet
* Checkbox label and description should only be announced once with a screen reader
When using multiple elements (span, etc) inside of a label, each one will be added as a screen reader "stop" and announced both as part of the label and as a separate text element.
Using this technique overrides this, to create the same experience as if the was only text inside of the label (native-like).
* Legg til mer realistiske tekster i eksempelet
* Remove aria-invalid from Checkbox and Radio, as it is redundant when we include an error message.
* Remove error message from example when we select an option
* Add error message to single description example to make it easier to test both
* Remove aria-describedby from Fieldset, because the error is connected to the input field
* 🐛 Fikset duplikat label-text funnet i tester
* Use local useId hook because of supporting React 17 and less
* Add changeset
---------
Co-authored-by: Ken <ken.aleksander@gmail.com>
Loaded 100 of 854 files, more files were not shown because too many files have changed in this diff.
Show more
Reference in new issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.